Skip to content

Do not build against libavif < 1 #8969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 2 commits into from
May 25, 2025
Merged

Do not build against libavif < 1 #8969

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45d1c41
Do not build against libavif < 1
radarhere May 22, 2025
5c2cabf
Merge branch 'main' into avif
radarhere May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,13 +224,14 @@ def _add_directory(
path.insert(where, subdir)


def _find_include_file(self: pil_build_ext, include: str) -> int:
def _find_include_file(self: pil_build_ext, include: str) -> str | None:
for directory in self.compiler.include_dirs:
_dbg("Checking for include file %s in %s", (include, directory))
if os.path.isfile(os.path.join(directory, include)):
path = os.path.join(directory, include)
if os.path.isfile(path):
_dbg("Found %s", include)
return 1
return 0
return path
return None


def _find_library_file(self: pil_build_ext, library: str) -> str | None:
Expand Down Expand Up @@ -852,9 +853,13 @@ def build_extensions(self) -> None:

if feature.want("avif"):
_dbg("Looking for avif")
if _find_include_file(self, "avif/avif.h"):
if _find_library_file(self, "avif"):
feature.set("avif", "avif")
if avif_h := _find_include_file(self, "avif/avif.h"):
with open(avif_h, "rb") as fp:
major_version = int(
fp.read().split(b"#define AVIF_VERSION_MAJOR ")[1].split()[0]
)
if major_version >= 1 and _find_library_file(self, "avif"):
feature.set("avif", "avif")

for f in feature:
if not feature.get(f) and feature.require(f):
Expand Down
Loading