Skip to content

Conversation

@wiredfool
Copy link
Member

This reverts commit e2e40c5.

Fixes #8954 (comment) .

Changes proposed in this pull request:

  • This reverts moving the cleanup for tiff encode into the cleanup function, as opposed to doing it in the actual encode
  • This is an intermittent issue on several of the platforms, it reasonably triggers using pytest -v --random-order Tests/test_file_libtiff.py on pypy3.10 on linux-x64
  • There's likely something else going on here, because the errors are on read and the changes are for write.

@radarhere
Copy link
Member

I've created #9002 as a possible alternative.

@wiredfool
Copy link
Member Author

I saw that, I haven't had a chance to test it yet. Probably Friday.

@radarhere
Copy link
Member

radarhere commented Jun 22, 2025

In the absence of any further discussion, I'll merge #9002 sometime in the next few days.

We're coming up on the release, and I would rather not merge it at the last minute.

@radarhere
Copy link
Member

#9002 has ben merged.

@radarhere radarhere closed this Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants