Skip to content

Commit

Permalink
Merge pull request #211 from radarhere/python38
Browse files Browse the repository at this point in the history
Drop support for Python 3.8 from manylinux build images
  • Loading branch information
radarhere committed Jul 3, 2024
2 parents 3668ec3 + cd2ff71 commit 9bbc4de
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 10 deletions.
2 changes: 0 additions & 2 deletions manylinux2014-wheel-build/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ wheel:
-[ ! -d out ] && mkdir out
docker run --rm -v $(ROOT):/Pillow -v `pwd`/out:/output $(IMAGENAME):$(BRANCH) /build.sh $(_PYVER)

38:
_PYVER=38 $(MAKE) wheel
39:
_PYVER=39 $(MAKE) wheel
310:
Expand Down
4 changes: 2 additions & 2 deletions manylinux2014-wheel-build/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ The Makefile has several new commands:

* make wheel: Makes a Python 3.12 manylinux2014 wheel, and puts it in the
./out directory.
* make 38|39|310|311|312: These are specific commands to make
the corresponding 3.x version in the ./out directory.
* make 39|310|311|312: These are specific commands to make the
corresponding 3.x version in the ./out directory.

The test target here is mainly to validate the image build, it is
assumed that the builds will be used for other purposes or tested in
Expand Down
2 changes: 1 addition & 1 deletion manylinux2014-wheel-build/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ fi
# not strictly necessary, unless running multiple versions from the shell
rm -f /tmp/*.whl || true

# Python version, as 38,39,310,311,312. Defaults to 312.
# Python version, as 39,310,311,312. Defaults to 312.
# Matches the naming in /opt/python/
PYVER=${1:-312}
PYBIN=$(echo /opt/python/cp${PYVER}*/bin)
Expand Down
2 changes: 0 additions & 2 deletions manylinux_2_28-wheel-build/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ wheel:
-[ ! -d out ] && mkdir out
docker run --rm -v $(ROOT):/Pillow -v `pwd`/out:/output $(IMAGENAME):$(BRANCH) /build.sh $(_PYVER)

38:
_PYVER=38 $(MAKE) wheel
39:
_PYVER=39 $(MAKE) wheel
310:
Expand Down
4 changes: 2 additions & 2 deletions manylinux_2_28-wheel-build/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ The Makefile has several new commands:

* make wheel: Makes a Python 3.12 manylinux_2_28 wheel, and puts it in the
./out directory.
* make 38|39|310|311|312: These are specific commands to make
the corresponding 3.x version in the ./out directory.
* make 39|310|311|312: These are specific commands to make the
corresponding 3.x version in the ./out directory.

The test target here is mainly to validate the image build, it is
assumed that the builds will be used for other purposes or tested in
Expand Down
2 changes: 1 addition & 1 deletion manylinux_2_28-wheel-build/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ fi
# not strictly necessary, unless running multiple versions from the shell
rm -f /tmp/*.whl || true

# Python version, as 38,39,310,311,312. Defaults to 312.
# Python version, as 39,310,311,312. Defaults to 312.
# Matches the naming in /opt/python/
PYVER=${1:-312}
PYBIN=$(echo /opt/python/cp${PYVER}*/bin)
Expand Down

0 comments on commit 9bbc4de

Please sign in to comment.