Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(completions): add quoting of command names #247

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

Secrus
Copy link
Member

@Secrus Secrus commented Sep 4, 2022

Resolves: python-poetry/poetry#133
Resolves: python-poetry/poetry#153
Resolves: #437
Resolves: python-poetry/poetry#4572
Resolves: python-poetry/poetry#3418

Initial fix to some of the completions issues. I have a refactor of the whole completion system on the way, but since it might take some time, I decided to cut it like this for now, so the shell errors are fixed.

@Secrus Secrus requested a review from a team September 5, 2022 07:43
@neersighted neersighted merged commit 011de8d into python-poetry:main Sep 6, 2022
@jeffbyrnes
Copy link

I kid you not, I was just coming here to see about contributing the quoting fixes. Thanks @neersighted!

jeffbyrnes added a commit to jeffbyrnes/dotfiles that referenced this pull request Sep 6, 2022
@Secrus Secrus deleted the fix/completions branch September 6, 2022 17:56
deantvv added a commit to deantvv/configs that referenced this pull request Oct 5, 2022
remove this when [PR](python-poetry/cleo#247) lands in upstream
deantvv added a commit to deantvv/dotfilesboot that referenced this pull request Jan 18, 2024
remove this when [PR](python-poetry/cleo#247) lands in upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants