Skip to content

Commit

Permalink
fix typing for ProjectPackage.python_versions
Browse files Browse the repository at this point in the history
  • Loading branch information
abn committed Mar 17, 2022
1 parent 5c741e6 commit e558314
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/poetry/core/factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def _add_package_group_dependencies(
)
for _constraint in _constraints:
if name.lower() == "python":
if group.name == "default":
if group.name == "default" and isinstance(_constraint, str):
package.python_versions = _constraint
continue

Expand Down
8 changes: 3 additions & 5 deletions src/poetry/core/packages/project_package.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,14 @@ def to_dependency(self) -> Union["DependencyTypes"]:
return dependency

@property
def python_versions(self) -> Union[str, "VersionConstraint"]:
def python_versions(self) -> str:
return self._python_versions

@python_versions.setter
def python_versions(self, value: Union[str, "VersionConstraint"]) -> None:
from poetry.core.semver.version_range import VersionRange

def python_versions(self, value: str) -> None:
self._python_versions = value

if value == "*" or value == VersionRange():
if value == "*":
value = "~2.7 || >=3.4"

self._python_constraint = parse_constraint(value)
Expand Down

0 comments on commit e558314

Please sign in to comment.