Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify temporary_directory and use safe_rmtree #119

Merged
merged 5 commits into from
Dec 31, 2020
Merged

Simplify temporary_directory and use safe_rmtree #119

merged 5 commits into from
Dec 31, 2020

Conversation

thejcannon
Copy link

@thejcannon thejcannon commented Dec 15, 2020 •
edited by finswimmer
Loading

Resolves: python-poetry/poetry#3493

  • Added tests for changed code.
  • Updated documentation for changed code.

Unit test fails without changes and passes with changes 🎉

@thejcannon thejcannon mentioned this pull request Dec 15, 2020
Closed
@finswimmer finswimmer requested a review from a team December 16, 2020 19:09
finswimmer
finswimmer requested changes Dec 19, 2020
View reviewed changes
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 👍

Just a minor thing.

tests/utils/test_helpers.py Show resolved Hide resolved
finswimmer
finswimmer approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot and happy new year 🚀

@finswimmer finswimmer merged commit 79bc4cb into python-poetry:master Dec 31, 2020
@Bettdatt
Copy link

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finswimmer finswimmer finswimmer approved these changes

Assignees
No one assigned
Labels
Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: poetry-core missing PR #1140, re-introducing bug #520
3 participants
@thejcannon @Bettdatt @finswimmer