Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output valid file URLs when building requirements #141

Merged

Conversation

AndrewGuenther
Copy link
Contributor

Resolves: python-poetry/poetry#3818

  • Added tests for changed code.
  • Updated documentation for changed code.

This code isn't currently covered by a test, but I can add one. I also didn't see any relevant docs to update but can if someone could point me to them.

Similar to the issue fixed by python-poetry/poetry#3121, file/directory dependencies in requirements.txt format (and transitively, in wheels) must be in URL format. Running pip install . for any poetry project containing a directory dependency will currently fail due to this issue.

poetry/core/packages/directory_dependency.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry run pip install . doesn't work with directory dependencies
2 participants