Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caret constraint parsing #171

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Fix caret constraint parsing #171

merged 1 commit into from
Apr 30, 2021

Conversation

sdispater
Copy link
Member

This PR fixes how caret constraints are parsed when the lower bound is a prerelease.

Basically, a constraint like ^1.0.0a3 was converted to >=1.0.0a3,<1.0.0 which cannot be satisfied.

The issue was coming from the Version.next_breaking() method which did not take the stable release as a starting point.

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater requested a review from a team April 29, 2021 08:21
@sdispater sdispater merged commit 5349ab2 into master Apr 30, 2021
@sdispater sdispater deleted the fix-caret-constraints branch April 30, 2021 09:09
@sdispater sdispater mentioned this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant