fix populate python constraints from markers #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
dimbleby
reviewed
Jan 26, 2022
| @@ -366,6 +367,10 @@ def create_dependency( | |||
| ) | |||
| else: | |||
| marker = parse_marker(markers) | |||
| # possibility that python constraint appears in markers, not keywords | |||
| if not python_versions and markers: | |||
There was a problem hiding this comment.
markers is known truth-y here, isn't it, making this check redundant?
| @@ -366,6 +367,10 @@ def create_dependency( | |||
| ) | |||
| else: | |||
| marker = parse_marker(markers) | |||
| # possibility that python constraint appears in markers, not keywords | |||
| if not python_versions and markers: | |||
| python_versions_marker = get_python_constraint_from_marker(marker) | |||
There was a problem hiding this comment.
why not just python_versions = get_python_constraint_from_marker(marker)?
dimbleby
reviewed
Feb 5, 2022
| # possibility that python constraint appears in markers, not keywords | ||
| if not python_versions and markers: | ||
| python_versions_marker = get_python_constraint_from_marker(marker) | ||
| python_versions = python_versions_marker |
There was a problem hiding this comment.
The result of this parse is never used, is it?
The test that you have added passes without the fix, which is consistent with this not doing anything.
Can you add a test that fails before the fix, and passes after it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry#