Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraint intersection #297

Merged
merged 3 commits into from
Feb 28, 2022

Conversation

dimbleby
Copy link
Contributor

Resolves: python-poetry#

  • Added tests for changed code.
  • Updated documentation for changed code.

I noticed that the implementation of intersection on the UnionConstraint was treating the intersection with a MultiConstraint in exactly the same way as the intersection with another UnionConstraint.

Well that can't be right, different inputs should give different outputs. Here's a fix.

@sonarcloud
Copy link

sonarcloud bot commented Feb 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.4% 0.4% Duplication

@neersighted neersighted merged commit 5e61d52 into python-poetry:master Feb 28, 2022
@finswimmer finswimmer mentioned this pull request Feb 28, 2022
@dimbleby dimbleby deleted the constraint-intersection branch February 28, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants