Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specification: add ignore_features flag to is_same_package_as #321

Conversation

radoering
Copy link
Member

@radoering radoering commented Apr 11, 2022

... as proposed in python-poetry/poetry#5435 (comment)

Update: Since allow_similar is too ambiguous the parameter is called ignore_features.

  • Added tests for changed code.
  • Updated documentation for changed code.

@radoering radoering force-pushed the is-same-package-allow-similar branch from f55db69 to d967a22 Compare April 16, 2022 06:23
@radoering radoering changed the title specification: add allow_similar flag to is_same_package_as specification: add ignore_features flag to is_same_package_as Apr 16, 2022
@radoering radoering force-pushed the is-same-package-allow-similar branch from d967a22 to 2fc8c41 Compare May 1, 2022 13:22
@sonarcloud
Copy link

sonarcloud bot commented May 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.7% 1.7% Duplication

@radoering
Copy link
Member Author

Superseded by #365. (Since is_same_source_as() plus name comparison fulfills the use case, introducing an additional parameter is not worth it anymore.)

@radoering radoering closed this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants