Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.0b3 #413

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Release 1.1.0b3 #413

merged 1 commit into from
Jul 12, 2022

Conversation

radoering
Copy link
Member

@radoering radoering commented Jul 9, 2022

Some poetry PRs have been waiting for a new poetry-core beta for some time now. Since the latest poetry beta pinned poetry-core to 1.1.0b2, the risk of a new beta should be low. Thus, I propose to just cut a new poetry-core beta.

(Order of sections according to python-poetry/poetry#5725 (comment).)

Added

  • Added support for valid PEP 517 projects with another build-system than poetry-core as directory dependencies (#368, #377).
  • Added support for yanked files and releases according to PEP 592 (#400).

Changed

  • Relaxed schema validation to allow additional properties (#369).
  • Harmonized string representation of dependencies (#393).
  • Changed wheel name normalization to follow most recent packaging specification (#394).
  • Changed equality check of direct origin dependencies, so that constraints are not considered anymore (#405).
  • Deprecated Dependency.set_constraint() and replaced it by a constraint property for consistency (#370).
  • Removed Package.requires_extras (#374).
  • Improved marker handling (#380, #383, #384, #390, #395).

Fixed

  • Fixed hash method for PackageSpecification, Package, Dependency and their sub classes (#370).
  • Fixed merging of markers python_version and python_full_version (#382, #388).
  • Fixed python version normalization (#385, #407).
  • Fixed an issue where version identifiers with a local version segment allowed non local versions (#396).
  • Fixed an issue where version identifiers without a post release segment allowed post releases (#396).
  • Fixed script definitions that didn't work when extras were not explicitly defined (#404).

@dimbleby
Copy link
Contributor

dimbleby commented Jul 9, 2022

Does this need still to be a beta? Why not release 1.1.0 proper?

(Arguably it should be 2.0.0 anyway because it surely has breaking changes since 1.0.x: but I'm more keen to encourage dropping the beta tag than I am to debate semantic versioning)

@radoering
Copy link
Member Author

I'm not aware of the full impact of a proper release. I suppose a beta does not influence projects with something like

[build-system]
requires = ["poetry-core>=1.0.0"]

whereas a proper release might. I suppose we will do the proper release of poetry-core immediately before poetry 1.2 and according to python-poetry/poetry#5586 we are still not close enough. (Just my personal opinion.)

@dimbleby
Copy link
Contributor

dimbleby commented Jul 9, 2022

fwiw I also think it's time to cut poetry 1.2.0 - all the blockers listed in python-poetry/poetry#5586 have fixes pending, let's merge them and go. But it really ought to be possible to cut releases in this project without being blocked on that.

@radoering radoering requested a review from a team July 11, 2022 15:22
Copy link
Member

@mkniewallner mkniewallner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless it was left out intentionally, #404 seems to be missing. In Fixed:

- Fixed script definitions that didn't work when extras were not explicitly defined ([#404](https://github.com/python-poetry/poetry-core/pull/404)).

CHANGELOG.md Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@radoering
Copy link
Member Author

Unless it was left out intentionally, #404 seems to be missing.

Slipped through my fingers. Added it. Thanks. 👍

@radoering radoering merged commit f9e81fd into python-poetry:main Jul 12, 2022
bostonrwalker pushed a commit to bostonrwalker/poetry-core that referenced this pull request Aug 29, 2022
@radoering radoering deleted the release/1.1.0b3 branch November 24, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants