Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use file:// urls for path and directory dependencies #512

Merged

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby force-pushed the direct-dependencies-in-wheels branch from 12964ce to a6a904e Compare October 30, 2022 18:50
@radoering
Copy link
Member

I wonder if this will break some "poetry-only" use cases where someone has a couple of projects relative to each other and everything works fine when the entire folder structure is moved.

Nevertheless, I think this fix is necessary because we are creating invalid PEP 508 names at the moment.

@radoering radoering force-pushed the direct-dependencies-in-wheels branch from a6a904e to b666183 Compare November 5, 2022 07:29
@sonarcloud
Copy link

sonarcloud bot commented Nov 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@radoering radoering merged commit b0b1823 into python-poetry:main Nov 5, 2022
@dimbleby dimbleby deleted the direct-dependencies-in-wheels branch November 5, 2022 10:43
@gregtesseract
Copy link

@radoering Could you please make a new release.
Really keen on using this change.

@neersighted
Copy link
Member

We are working on a new release (and it's linked here); as this will have to be coordinated with a Poetry release (and you, as a user of the poetry frontend won't benefit until it's shipped by Poetry), you can follow progress there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants