Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Package.platform #548

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Jan 5, 2023

Companion to python-poetry/poetry#7304: the package platform is unused

@dimbleby
Copy link
Contributor Author

dimbleby commented Jan 5, 2023

(downstream tests won't pass until python-poetry/poetry#7304 propagates, so this won't be mergeable for a while)

@dimbleby dimbleby force-pushed the unused-platform branch 2 times, most recently from adbbdc6 to b3bdb6a Compare January 21, 2023 11:37
@dimbleby
Copy link
Contributor Author

dropping the poetry 1.3 downstream tests should have made this mergeable

@sonarcloud
Copy link

sonarcloud bot commented Jan 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@radoering radoering changed the title Package.platform is unused Remove unused Package.platform Jan 21, 2023
@radoering radoering merged commit 298d85c into python-poetry:main Jan 21, 2023
@dimbleby dimbleby deleted the unused-platform branch January 21, 2023 14:47
@radoering radoering mentioned this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants