Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't commit poetry.lock #554

Closed

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented Feb 8, 2023

As python-poetry/poetry#7488 notes, poetry's own documentation recommends not committing lockfiles for libraries.

This project should practice what it preaches.

(It could be reasonable to reject this MR on the grounds that it's in some way more complicated than that - but then the docs should acknowledge that complication)

@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@radoering
Copy link
Member

I'm a slight -1 for this and +1 for changing the docs because with a lock file you always know which dependencies work for sure. Without a lock file, you will get more failures unrelated to your changes. Then, you'll have to realize the failure has nothing to do with your change, search for a successful CI run, check if some dependency changed, ...

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@ralbertazzi
Copy link

Now that python-poetry/poetry#7506 has been merged I think the documentation is aligned with us keeping the lock file. I would close this PR, and - why not - have a round of dependencies update as the documentation suggests :)

@radoering
Copy link
Member

I'll close this for now since no maintainer has expressed agreement so far and the documentation no longer recommends not to commit the lockfile.

@radoering radoering closed this May 27, 2023
@dimbleby dimbleby deleted the dont-commit-poetry-lock branch May 27, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants