Use importlib.resources to load schema and licenses

[edgarrmondragon]

Again, this is one step towards resolving python-poetry/poetry#2965.

• Added tests for changed code.
• Updated documentation for changed code.

Another attempt after #668 fell through.

[dimbleby]

my overall feeling is that this is a lot of code to be vendoring for a rather niche use case - poetry in a zipapp - which, presumably, has been unsupported for all this time anyway.

Maybe wait until python 3.8 goes eol next year and then come back to this?

[dimbleby]

<3.9 is not helpful here: importlib-resources has to be either vendored with poetry-core, or not.

This is a decision that is made at make vendor/update time: it is not desirable that maintainers and contributors using different python versions get different answers

[edgarrmondragon]

I've removed the vendored code per #670 (comment)

[radoering]

I'd like to avoid additional vendoring, too. An alternative to waiting for the EOL of Python 3.8 might be to keep the old way for Python 3.8 and only use importlib.resources for Python 3.9 and above.

[edgarrmondragon]

I'd like to avoid additional vendoring, too. An alternative to waiting for the EOL of Python 3.8 might be to keep the old way for Python 3.8 and only use importlib.resources for Python 3.9 and above.

That makes sense to me 👍

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[edgarrmondragon]

@radoering @dimbleby this is ready for another review 🙂