Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build formats dict openly available #679

Closed
wants to merge 1 commit into from

Conversation

Secrus
Copy link
Member

@Secrus Secrus commented Jan 4, 2024

  • Added tests for changed code. No significant changes.

This allows for poetry plugins to easily register custom builders. Small change, I don't see any tests that would be needed for that.

Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Secrus Secrus requested a review from a team January 5, 2024 02:03
@radoering
Copy link
Member

Do you have an example for such a plugin?

@Secrus
Copy link
Member Author

Secrus commented Jan 5, 2024

Do you have an example for such a plugin?

A plugin for building distro-specific packages (.deb, .rpm) for example.

@radoering
Copy link
Member

radoering commented Jan 6, 2024

Probably obsolete if we decide for #680 (comment). I suppose it's better to have an interface for poetry plugins somewhere in poetry itself instead of poetry-core anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants