Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance readme handling #752

Merged
merged 6 commits into from
Sep 8, 2024
Merged

Enhance readme handling #752

merged 6 commits into from
Sep 8, 2024

Conversation

rindeal
Copy link
Contributor

@rindeal rindeal commented Aug 30, 2024

In my config file I wrote readme = "" and poetry install cmd then failed with a nondescript message that looked like this:

Installing the current project: my-project (0.1.0)
[Errno 21] Is a directory: '/home/runner/work/my-project/my-project'

This PR attempts to fix this.

  • Updated documentation for changed code.
  • Added tests for changed code.

Either add the tests yourselves or please advise on the best way to test the new code for 100% coverage.

@radoering radoering merged commit cce0297 into python-poetry:main Sep 8, 2024
20 checks passed
@rindeal
Copy link
Contributor Author

rindeal commented Sep 9, 2024

nice, thanks

@rindeal rindeal deleted the patch-1 branch September 9, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants