Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nested directory support for wheel #762

Merged
merged 5 commits into from
Sep 29, 2024
Merged

fix: nested directory support for wheel #762

merged 5 commits into from
Sep 29, 2024
+37 −1

Conversation

AsifArmanRahman
Copy link
Contributor

@AsifArmanRahman AsifArmanRahman commented Sep 28, 2024 •
edited by radoering
Loading

Resolves: python-poetry/poetry#9721

  • Added tests for changed code.
  • Updated documentation for changed code.

radoering
radoering approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I improved the test a bit and added an analoguous test for sdists.

Hint: The # type: ignore was only necessary because the type hint had been wrong.

@radoering radoering merged commit d066ef6 into python-poetry:main Sep 29, 2024
21 checks passed
@radoering radoering mentioned this pull request Sep 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radoering radoering radoering approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non existing nested directory output support for wheel
2 participants
@AsifArmanRahman @radoering