Use pkgutil.get_data for zip-safe resource loading #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinoroc
force-pushed
the
zip-safe-loading-of-package-data
branch
from
c2d8022 to
1a99dd3
Compare
When running from a Zip file (`zipapp`, `*.pyz`), loading resources from package data can not be done by directly reading files relative to `__file__`, since there is no valid path on the file system for zipped files. Using `pkgutil.get_data` ensures that loading files from a Zip archive is handled accordingly. Resolves: python-poetry/poetry#2965
sinoroc
force-pushed
the
zip-safe-loading-of-package-data
branch
from
1a99dd3 to
9f34a86
Compare
|
Closing for now as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running from a Zip file (
zipapp,*.pyz), loading resourcesfrom package data can not be done by directly reading files relative
to
__file__, since there is no valid path on the file system forzipped files.
Using
pkgutil.get_dataensures that loading files from a Zip archiveis handled accordingly.
Resolves: python-poetry/poetry#2965