-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency resolution doesn't take platform into account. #224
Comments
Yes. Seems I wasn't as intelligent as I could have been though.
#186 actually has the same setup, albeit with I don't want to clutter up the issue tracker with noise: feel free to close this as a dupe. |
-vvv
option) and have included the output below.Attempting to export the above pyproject.toml throws an error, since
walker.py
thinks there are overlappingIssue
Attempting to export the above pyproject.toml throws a runtime error.
sentence-transformers
declares that it depends ontorchvision
. Currentlywalker.py
doesn't take the platform into account, so it thinks that these dependencies are overlapping and fails. Setting a breakpoint onwalker.py::get_locked_package
confirms that the explicit passes fortorchvision
are fine: it's the pass forsentence-transformers
which can't work out which to pick.Looking at the lockfile I can't see where (if anywhere) the platform information is actually stored in it. Should it be? Or should the exporter consult pyproject.toml?
Traceback
The text was updated successfully, but these errors were encountered: