Handle multiple extras and invalid extras #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KotlinIsland
force-pushed
the
main
branch
2 times, most recently
from
944b73a to
43c9440
Compare
dimbleby
reviewed
Aug 28, 2022
src/poetry_plugin_export/command.py
Outdated
| # Checking extras | ||
| extras = [] | ||
| for extra in self.option("extras"): | ||
| if " " in extra: |
There was a problem hiding this comment.
I realise I pointed you at code like this to copy, but it occurs to me now that the two branches are unnecessary, this first branch works fine for both cases.
There was a problem hiding this comment.
in fact come to think of it isn't this whole thing just
extras += extra.split()There was a problem hiding this comment.
Not quite, I think it would be:
extras.extend(extra.split())Anyway I changed it to a double comprehension, 🤞 I don't get sent straight to hell
There was a problem hiding this comment.
I think my formulation was fine and I like it a little better, but it's not worth arguing over!
KotlinIsland
force-pushed
the
main
branch
2 times, most recently
from
ce50916 to
a6cb5ab
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Closed
dimbleby
approved these changes
Aug 29, 2022
radoering
approved these changes
Sep 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #31
resolves: #33