Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle circular dependency on root package (fix #118) #121

Merged
merged 2 commits into from
Jan 7, 2023
Merged

Handle circular dependency on root package (fix #118) #121

merged 2 commits into from
Jan 7, 2023

Conversation

brechtm
Copy link
Contributor

@brechtm brechtm commented Sep 16, 2022 •
edited by radoering
Loading

Resolves: #118

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dimbleby dimbleby mentioned this pull request Oct 1, 2022
Merged
@brechtm brechtm force-pushed the circular branch 2 times, most recently from 706fccf to 2e20004 Compare December 7, 2022 11:33
@brechtm brechtm marked this pull request as ready for review December 7, 2022 11:35
@brechtm
Copy link
Contributor Author

brechtm commented Dec 7, 2022

I finally got around to adding a test case. Please review.

radoering
radoering requested changes Dec 18, 2022
View reviewed changes
tests/test_exporter.py Outdated Show resolved Hide resolved
tests/test_exporter.py Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.7% 5.7% Duplication

@brechtm
Copy link
Contributor Author

brechtm commented Jan 6, 2023 •
edited
Loading

Thanks for your suggestions, @radoering. I have included the changes in my last commit.

@radoering radoering merged commit ead1dfb into python-poetry:main Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimbleby dimbleby dimbleby left review comments

@radoering radoering radoering approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to export a package with a circular dependency
3 participants
@brechtm @dimbleby @radoering