Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump minimum Poetry/poetry-core version and drop compat code #143

Merged
merged 2 commits into from
Oct 11, 2022
Merged

chore: bump minimum Poetry/poetry-core version and drop compat code #143

merged 2 commits into from
Oct 11, 2022

Conversation

neersighted
Copy link
Member

@neersighted neersighted commented Oct 11, 2022 •
edited
Loading

Now that 1.2.2 is out we can bump the minimum version requirement for this plugin.

This should unblock #104.

radoering
radoering requested changes Oct 11, 2022
View reviewed changes
Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to remove the unused "type ignore". Further, one of the canonicalize_name in command.py can be removed because package.extras is always normalized now.

pyproject.toml Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.5% 6.5% Duplication

@neersighted
Copy link
Member Author

Good catch, I've pushed the two changes.

@neersighted neersighted requested a review from radoering October 11, 2022 04:54
@neersighted neersighted enabled auto-merge (squash) October 11, 2022 05:00
@neersighted neersighted merged commit b6dbe8f into python-poetry:main Oct 11, 2022
@neersighted neersighted deleted the require_core_1.3 branch October 11, 2022 05:20
@radoering radoering mentioned this pull request Nov 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radoering radoering radoering approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neersighted @radoering