Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update import of deprecated repository modules #151

Merged
merged 2 commits into from
Nov 1, 2022
Merged

fix: update import of deprecated repository modules #151

merged 2 commits into from
Nov 1, 2022

Conversation

b-kamphorst
Copy link
Contributor

Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the imports forward compatible please? The scheme is try "new import" except "old import". Proposals below. You probably have to add some "type: ignore" or similar to satisfy mypy and flake8.

src/poetry_plugin_export/exporter.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@b-kamphorst
Copy link
Contributor Author

Can you make the imports forward compatible please? The scheme is try "new import" except "old import". Proposals below. You probably have to add some "type: ignore" or similar to satisfy mypy and flake8.

Indeed, the current PR is valid only for "poetry = ^1.3.0" so that it is valid only after poetry 1.3.0 is released. I have made it backwards compatible in the way you describe so that we can release it already. If this PR is released only after the release of poetry 1.3.0, you may consider dropping the last commit (and require poetry = ^1.3.0).

@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@b-kamphorst b-kamphorst marked this pull request as ready for review November 1, 2022 01:18
@radoering
Copy link
Member

Yeah, if poetry-plugin-export and poetry would not be so closely coupled we could just wait. Unfortunately, we are still delivering poetry-plugin-export with poetry. (We intend to stop doing this. Another maintainer has already created a proof-of-concept on how to proceed in a gracefully way but he hasn't been available lately.) That's why we want to release a version of poetry-plugin-export that can be delivered with poetry 1.3 and will not trigger a deprecation warning.

@radoering radoering merged commit 3f27c6b into python-poetry:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants