Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a '--all-extras' option #241

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Add a '--all-extras' option #241

merged 2 commits into from
Oct 30, 2023

Conversation

pouillon
Copy link
Contributor

In my team, we are exporting the dependencies of some of our packages with the information from all extras to make sure that we have the same environment for different test and deployment scenarios. With time, we have been adding more extras and have had to update our configurations each time there is a new extra.

With this option, we don't have to care anymore about the extras explicitly and know that we'll always have the information we need correctly exported. We hope that this would be useful enough for other packages to be integrated into the official version of this plugin.

@dimbleby
Copy link
Contributor

#105

@radoering radoering mentioned this pull request Oct 29, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to apply the review feedback myself so I can include this feature in the next release without having to wait. 🙂

@radoering radoering merged commit 2428cdd into python-poetry:main Oct 30, 2023
18 checks passed
@pouillon
Copy link
Contributor Author

Thank you for merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants