Skip to content

Commit

Permalink
Merge pull request #1320 from toppk/develop
Browse files Browse the repository at this point in the history
remove NoReturn, use None instead
  • Loading branch information
brycedrennan authored Aug 24, 2019
2 parents 335da0d + 7b07ae0 commit 4d87bba
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions poetry/utils/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

from contextlib import contextmanager
from typing import List
from typing import NoReturn
from typing import Optional

from keyring import delete_password, set_password, get_password
Expand Down Expand Up @@ -102,7 +101,7 @@ def keyring_repository_password_get(

def keyring_repository_password_set(
repository_name, username, password
): # type: (str, str, str) -> NoReturn
): # type: (str, str, str) -> None
try:
set_password(keyring_service_name(repository_name), username, password)
except (RuntimeError, KeyringError):
Expand All @@ -111,7 +110,7 @@ def keyring_repository_password_set(

def keyring_repository_password_del(
config, repository_name
): # type: (Config, str) -> NoReturn
): # type: (Config, str) -> None
try:
repo_auth = config.get("http-basic.{}".format(repository_name))
if repo_auth and "username" in repo_auth:
Expand Down

0 comments on commit 4d87bba

Please sign in to comment.