directory dependency - resolve relative paths

python-poetry · Feb 15, 2020 · ebb97f0 · ebb97f0
1 parent ed44342
commit ebb97f0
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/poetry/packages/directory_dependency.py b/poetry/packages/directory_dependency.py
@@ -32,6 +32,8 @@ def __init__(
         if self._base and not self._path.is_absolute():
             self._full_path = self._base / self._path
 
+        self._full_path = self._full_path.resolve()
+
         if not self._full_path.exists():
             raise ValueError("Directory {} does not exist".format(self._path))
 

diff --git a/tests/packages/test_directory_dependency.py b/tests/packages/test_directory_dependency.py
@@ -1,3 +1,4 @@
+import os
 from subprocess import CalledProcessError
 
 import pytest
@@ -19,3 +20,25 @@ def run(self, bin, *args):
 def test_directory_dependency_must_exist():
     with pytest.raises(ValueError):
         DirectoryDependency("demo", DIST_PATH / "invalid")
+
+
+def test_directory_relative_path():
+    assert (
+        DirectoryDependency(
+            "demo",
+            Path(
+                os.path.sep.join(
+                    [
+                        str(Path(__file__).parent),
+                        "..",
+                        "fixtures",
+                        "git",
+                        "github.com",
+                        "demo",
+                        "demo",
+                    ]
+                )
+            ),
+        ).full_path
+        == DIST_PATH / "demo"
+    )