Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding git dependency from subproject failes #1746

Closed
3 tasks done
finswimmer opened this issue Dec 16, 2019 · 3 comments · Fixed by #1756
Closed
3 tasks done

Adding git dependency from subproject failes #1746

finswimmer opened this issue Dec 16, 2019 · 3 comments · Fixed by #1756
Assignees
Labels
kind/bug Something isn't working as expected

Comments

@finswimmer
Copy link
Member

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).
  • Poetry version: 1.0.0.

Issue

At least with gitlab it is possible to organize your repositories in project and subprojects. This results in longer path names, e.g. https://example.org/project/subproject/rep.git

Trying to add this to a poetry project results in:

[CalledProcessError]
Command '['git', 'clone', 'git+https://example.org/project/subproject/rep.git', '/tmp/pypoetry-git-repuqxf81sd']' returned non-zero exit status 128.

The cause for this is that no regex in git.py matches this path.

I've already started to fix it.

fin swimmer

@languitar
Copy link

languitar commented Feb 20, 2020

This is still not solved generically, even with Gitlab. URLs of the following form also do not work:

git+https://gitlab.com/org.withdot/group/project.git#12345678"

@languitar
Copy link

Ok, I see, there is a fix for that case on master, but it hasn't been released yet.

Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants