Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse git+https with URL formats different from Github does not work #1857

Closed
Shawe82 opened this issue Jan 10, 2020 · 2 comments
Closed

Parse git+https with URL formats different from Github does not work #1857

Shawe82 opened this issue Jan 10, 2020 · 2 comments
Labels
kind/bug Something isn't working as expected

Comments

@Shawe82
Copy link

Shawe82 commented Jan 10, 2020

  • [ x] I am on the latest Poetry version.

  • [ x] I have searched the issues of this repo and believe that this is not a duplicate.

  • [ x] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

  • OS version and name: MAC OS

  • **Poetry version : 1.0.0

Issue

Add git dependencies with https to URLs that differ from the URL format used by github does not work. I am using gitlab. The URL structure is like https://gitlab.something.io/f1/f2/my-repo.git. If I try to add that using

poetry add git+https://gitlab.something.io/f1/f2/my-repo.git

The URL is parsed incorrectly or rather not at all. This results in poetry executing

git clone  git+https://gitlab.something.io/f1/f2/my-repo.git

which certainly does not work because of the leading git+. From playing around, I think github URLS look like https://main-url/username/my-repo.git. The regex parser seems to expect something like that. However, gitlab can have several layers after the main URL until the actual repo name. This is not parsed correctly. Hence, I cannot add the repo using https. With ssh, everything works like a charm.

@Shawe82 Shawe82 added the kind/bug Something isn't working as expected label Jan 10, 2020
@finswimmer
Copy link
Member

Hello @Shawe82,

this is a duplicate of #1746 and will be fixed in the next release.

fin swimmer

Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

2 participants