Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Build Backend Interface described in PEP 517 #191

Closed
cauebs opened this issue Jun 7, 2018 · 11 comments
Closed

Implement the Build Backend Interface described in PEP 517 #191

cauebs opened this issue Jun 7, 2018 · 11 comments

Comments

@cauebs
Copy link
Contributor

cauebs commented Jun 7, 2018

I think it would help adoption if we could use poetry without requiring our users to also use it. I see that poetry publish already generates it. Is there any reason not to include a flag in, for example, poetry build to write it in the project root?

@ambv
Copy link

ambv commented Jun 9, 2018

The point is not to have setup.py anymore. Instead, the next version of pip will be able to install packages that have pyproject.toml (see PEP 518 for details) and don't have setup.py. That will require support for [build-system] in Poetry. IIUC, this is a planned feature here.

@cauebs
Copy link
Contributor Author

cauebs commented Jun 9, 2018

Oh, I see. Isn't there an issue regarding this? Should I close this and open one?

@Victor-Savu
Copy link

Victor-Savu commented Jun 9, 2018

@ambv I am a little confused. I thought that:

  1. The current version of pip (10.x) already installs packages using pyproject.tomlas per PEP 518.
  2. poetry already acts as a build system tool (as defined in PEP 517).
    Have I been dreaming? :)

@ambv
Copy link

ambv commented Jun 9, 2018

@Victor-Savu, oh, if pip 10 already does that then great.

What do you put in your [build-system] section of your pyproject.toml to make pip install your poetry-powered package?

@Victor-Savu
Copy link

Victor-Savu commented Jun 10, 2018

@ambv whoops, I have indeed been dreaming (Present and future were intermingling. Electric sheep were jumping around). pip only added support for PEP 518 and not for PEP 517 (here is the tracking issue for PEP 517 support: pypa/pip#5407) This is mainly because PEP 517 is only provisionally accepted (pending real-world experience from tools such as pip).

Sorry for the confusion! Indeed, poetry would need to be prepared to implement the Build Backend Interface described in PEP 517 in order to be used by pip.

@cs01 cs01 mentioned this issue Jun 17, 2018
@orsinium
Copy link

I need this feature and create simple tool for this: poetry-setup. Try it, if someone want it too :)

@cauebs cauebs changed the title Add ability to generate setup.py from pyproject.toml Implement the Build Backend Interface described in PEP 517 Jun 28, 2018
@digitalresistor
Copy link
Contributor

With tox supporting isolated_build is there a way to set poetry as the build backend?

This would allow us to use tox for testing across multiple versions more easily.

@sdispater
Copy link
Member

@bertjwregeer This has been added in commit 8055bcf. It will be officially available in the next 0.12 release.

I will try to make another alpha build this week so that it can be tested. 

@digitalresistor
Copy link
Contributor

@sdispater Awesome. I am sorry I missed the commit!

@sdispater
Copy link
Member

A PEP-517 compliant build system is now available: https://poetry.eustace.io/docs/pyproject/#poetry-and-pep-517

Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants