Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox support #222

Closed
sobolevn opened this issue Jun 16, 2018 · 10 comments
Closed

tox support #222

sobolevn opened this issue Jun 16, 2018 · 10 comments

Comments

@sobolevn
Copy link
Contributor

sobolevn commented Jun 16, 2018

Hi, thanks for this awesome package. It look really promising.

Here's my problem: I am using tox and pyproject.toml for my library.
When trying to use them together that's what happens:

» tox
ERROR: No setup.py file found. The expected location is:
  /Users/sobolev/Documents/github/mimesis-factory/setup.py
You can
  1. Create one:
     https://packaging.python.org/tutorials/distributing-packages/#setup-py
  2. Configure tox to avoid running sdist:
     http://tox.readthedocs.io/en/latest/example/general.html#avoiding-expensive-sdist

What is the recommended solution for this workflow?
The only thing that I do not want to do is returning to the old setup.py.

@rcisterna
Copy link

Hi, I'm in the same situation here. It seems like this is a tox issue, which depends on a pip issue.

I really hope that all this awesome tools implements PEP-517 and PEP-518 soon.

@sdispater
Copy link
Member

For now, you can use poetry with tox by using something similar to what I did in pendulum: https://github.com/sdispater/pendulum/blob/master/tox.ini

@vberlier
Copy link

Thanks a heap I was just wondering how tox would work without any setup.py. Perfect timing!

@valignatev
Copy link
Contributor

If we'd think about setup.py as some kind of a lock file which you never generate by hand, maybe an option for poetry lock which generates setup.py might be helpful. Of course, it doesn't work for those who want to avoid storing setup.py in their repo. Just brainstorming here.

@cs01
Copy link

cs01 commented Jun 17, 2018

@valignatev this was suggested in #191

@tadeoos
Copy link
Contributor

tadeoos commented Jun 17, 2018

I think it would be a good idea to add the pendulum example to FAQ (or start a wiki?)

@tadeoos
Copy link
Contributor

tadeoos commented Jun 19, 2018

I think we can close this issue for now

@sobolevn
Copy link
Contributor Author

Yeap, #227 solves the problem. Thanks everyone!

@mlissner
Copy link

For those arriving here, the solution mentioned in #227 is this link: https://python-poetry.org/docs/faq/#is-tox-supported

Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants