Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poetry does not prefer custom repository but docs say it does #2564

Closed
3 tasks done
MrGreenTea opened this issue Jun 16, 2020 · 2 comments
Closed
3 tasks done

poetry does not prefer custom repository but docs say it does #2564

MrGreenTea opened this issue Jun 16, 2020 · 2 comments
Labels
kind/bug Something isn't working as expected

Comments

@MrGreenTea
Copy link
Contributor

MrGreenTea commented Jun 16, 2020 •
edited
Loading

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

Issue

When adding a custom repository that contains a package that also exists on pypi.org, it will be downloaded from pypi.org.
My use case is adding a wheel for typed-ast to my custom repo that works on windows and python 3.9, as such a wheel is not provided on pypi.org yet.
Sadly this does not work and installation on windows fails.
In the docs it says

Any custom repository will have precedence over PyPI.

The wheel also does not appear in poetry.lock:

typed-ast = [
    {file = "typed_ast-1.4.1-cp35-cp35m-manylinux1_i686.whl", hash = "sha256:73d785a950fc82dd2a25897d525d003f6378d1cb23ab305578394694202a58c3"},
    {file = "typed_ast-1.4.1-cp35-cp35m-manylinux1_x86_64.whl", hash = "sha256:aaee9905aee35ba5905cfb3c62f3e83b3bec7b39413f0a7f19be4e547ea01ebb"},
    {file = "typed_ast-1.4.1-cp35-cp35m-win32.whl", hash = "sha256:0c2c07682d61a629b68433afb159376e24e5b2fd4641d35424e462169c0a7919"},
    {file = "typed_ast-1.4.1-cp35-cp35m-win_amd64.whl", hash = "sha256:4083861b0aa07990b619bd7ddc365eb7fa4b817e99cf5f8d9cf21a42780f6e01"},
    {file = "typed_ast-1.4.1-cp36-cp36m-macosx_10_9_x86_64.whl", hash = "sha256:269151951236b0f9a6f04015a9004084a5ab0d5f19b57de779f908621e7d8b75"},
    {file = "typed_ast-1.4.1-cp36-cp36m-manylinux1_i686.whl", hash = "sha256:24995c843eb0ad11a4527b026b4dde3da70e1f2d8806c99b7b4a7cf491612652"},
    {file = "typed_ast-1.4.1-cp36-cp36m-manylinux1_x86_64.whl", hash = "sha256:fe460b922ec15dd205595c9b5b99e2f056fd98ae8f9f56b888e7a17dc2b757e7"},
    {file = "typed_ast-1.4.1-cp36-cp36m-win32.whl", hash = "sha256:4e3e5da80ccbebfff202a67bf900d081906c358ccc3d5e3c8aea42fdfdfd51c1"},
    {file = "typed_ast-1.4.1-cp36-cp36m-win_amd64.whl", hash = "sha256:249862707802d40f7f29f6e1aad8d84b5aa9e44552d2cc17384b209f091276aa"},
    {file = "typed_ast-1.4.1-cp37-cp37m-macosx_10_9_x86_64.whl", hash = "sha256:8ce678dbaf790dbdb3eba24056d5364fb45944f33553dd5869b7580cdbb83614"},
    {file = "typed_ast-1.4.1-cp37-cp37m-manylinux1_i686.whl", hash = "sha256:c9e348e02e4d2b4a8b2eedb48210430658df6951fa484e59de33ff773fbd4b41"},
    {file = "typed_ast-1.4.1-cp37-cp37m-manylinux1_x86_64.whl", hash = "sha256:bcd3b13b56ea479b3650b82cabd6b5343a625b0ced5429e4ccad28a8973f301b"},
    {file = "typed_ast-1.4.1-cp37-cp37m-win32.whl", hash = "sha256:d5d33e9e7af3b34a40dc05f498939f0ebf187f07c385fd58d591c533ad8562fe"},
    {file = "typed_ast-1.4.1-cp37-cp37m-win_amd64.whl", hash = "sha256:0666aa36131496aed8f7be0410ff974562ab7eeac11ef351def9ea6fa28f6355"},
    {file = "typed_ast-1.4.1-cp38-cp38-macosx_10_15_x86_64.whl", hash = "sha256:d205b1b46085271b4e15f670058ce182bd1199e56b317bf2ec004b6a44f911f6"},
    {file = "typed_ast-1.4.1-cp38-cp38-manylinux1_i686.whl", hash = "sha256:6daac9731f172c2a22ade6ed0c00197ee7cc1221aa84cfdf9c31defeb059a907"},
    {file = "typed_ast-1.4.1-cp38-cp38-manylinux1_x86_64.whl", hash = "sha256:498b0f36cc7054c1fead3d7fc59d2150f4d5c6c56ba7fb150c013fbc683a8d2d"},
    {file = "typed_ast-1.4.1-cp38-cp38-win32.whl", hash = "sha256:715ff2f2df46121071622063fc7543d9b1fd19ebfc4f5c8895af64a77a8c852c"},
    {file = "typed_ast-1.4.1-cp38-cp38-win_amd64.whl", hash = "sha256:fc0fea399acb12edbf8a628ba8d2312f583bdbdb3335635db062fa98cf71fca4"},
    {file = "typed_ast-1.4.1-cp39-cp39-macosx_10_15_x86_64.whl", hash = "sha256:d43943ef777f9a1c42bf4e552ba23ac77a6351de620aa9acf64ad54933ad4d34"},
    {file = "typed_ast-1.4.1.tar.gz", hash = "sha256:8c8aaad94455178e3187ab22c8b01a3837f8ee50e09cf31f1ba129eb293ec30b"},
]

When I set my custom repository as default and add pypi.org as secondary, it works:

[[tool.poetry.source]]
name = "custom"
url = "https://example.org/index/+simple"
default = true
[[tool.poetry.source]]
name = "default"
url = 'https://pypi.python.org/simple'
secondary = true

With that the poetry.lock contains:

typed-ast = [
    ...
    {file = "typed_ast-1.4.1-cp39-cp39-win32.whl", hash = "sha256:69ee4041ce108cfcaba2b3ce98bfc3d7c87475baabc01c633088cb6afa214d91"},
    {file = "typed_ast-1.4.1-cp39-cp39-win_amd64.whl", hash = "sha256:d0f8433031f09b91d4500ae20edae06b23511369b5bfd1ebf25fa474fe06a03c"},
    {file = "typed_ast-1.4.1.tar.gz", hash = "sha256:8c8aaad94455178e3187ab22c8b01a3837f8ee50e09cf31f1ba129eb293ec30b"},
]
@MrGreenTea MrGreenTea added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Jun 16, 2020
linw1995 added a commit to linw1995/poetry that referenced this issue Jul 16, 2020
@linw1995
Fixes custom repositories with wrong precedence
ef9501a 
Relates-to: python-poetry#2564 python-poetry#1677
@linw1995 linw1995 mentioned this issue Jul 16, 2020
Closed
2 tasks
@jaklan jaklan mentioned this issue Oct 19, 2020
Closed
3 tasks
abn added a commit to abn/poetry that referenced this issue Oct 19, 2020
@abn
pool: ensure sources are prioritised over PyPI
e7cc2d9 
When a project specifies non default sources, PyPI gets added as the
default source. This will prioritise packages available in PyPI when
the package exists in both index. This change ensures that PyPI is
only used as a default when no other sources are provided.

Resolves: python-poetry#1677 python-poetry#2564 python-poetry#3238
@abn abn mentioned this issue Oct 19, 2020
Merged
abn added a commit to abn/poetry that referenced this issue Oct 19, 2020
@abn
pool: ensure sources are prioritised over PyPI
1051e5f 
When a project specifies non default sources, PyPI gets added as the
default source. This will prioritise packages available in PyPI when
the package exists in both index. This change ensures that PyPI is
only used as a default when no other sources are provided.

Resolves: python-poetry#1677 python-poetry#2564 python-poetry#3238
abn added a commit to abn/poetry that referenced this issue Oct 19, 2020
@abn
pool: ensure sources are prioritised over PyPI
74fc8eb 
When a project specifies non default sources, PyPI gets added as the
default source. This will prioritise packages available in PyPI when
the package exists in both index. This change ensures that PyPI is
only used as a default when no other sources are provided.

Resolves: python-poetry#1677 python-poetry#2564 python-poetry#3238
abn added a commit to abn/poetry that referenced this issue Oct 23, 2020
@abn
pool: ensure sources are prioritised over PyPI
36b8c67 
When a project specifies non default sources, PyPI gets added as the
default source. This will prioritise packages available in PyPI when
the package exists in both index. This change ensures that PyPI is
only used as a default when no other sources are provided.

Resolves: python-poetry#1677 python-poetry#2564 python-poetry#3238
@abn abn mentioned this issue Oct 23, 2020
Merged
abn added a commit that referenced this issue Oct 23, 2020
@abn
pool: ensure sources are prioritised over PyPI
3067fd4 
When a project specifies non default sources, PyPI gets added as the
default source. This will prioritise packages available in PyPI when
the package exists in both index. This change ensures that PyPI is
only used as a default when no other sources are provided.

Resolves: #1677 #2564 #3238
@abn abn removed the status/triage This issue needs to be triaged label Oct 23, 2020
@abn
Copy link
Member

abn commented Oct 23, 2020

Resolved with 1.1.4.

@abn abn closed this as completed Oct 23, 2020
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes custom repositories with wrong precedence linw1995/poetry
2 participants
@abn @MrGreenTea