Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag to install all extras #3413

Closed
2 tasks done
l0b0 opened this issue Nov 25, 2020 · 12 comments · Fixed by #5452
Closed
2 tasks done

Flag to install all extras #3413

l0b0 opened this issue Nov 25, 2020 · 12 comments · Fixed by #5452
Labels
area/cli Related to the command line kind/feature Feature requests/implementations

Comments

@l0b0
Copy link

l0b0 commented Nov 25, 2020

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

It would be handy to have a flag like --all-extras to install every package listed in any of the extras.

The specific use case is that I want the IDE to index the packages for every subsystem (AWS Lambda jobs in this case) for easier development.

Workarounds:

  1. Creating a separate "extra" section with all the packages from all the other extras (example). This means duplication, which means it would be really easy for the sections to get out of sync.
  2. Listing each extra specifically in the developer instructions.
  3. This ugly code, used in anger here: poetry install --extras="$(sed --quiet '/\[tool\.poetry\.extras\]/,/^\[/{s/^\(.*\) = \[/\1/p}' pyproject.toml | sed --null-data 's/\n/ /g;s/ $//')" --remove-untracked
@l0b0 l0b0 added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Nov 25, 2020
@sinoroc
Copy link

sinoroc commented Nov 25, 2020

Related: #3369

@finswimmer finswimmer added the area/cli Related to the command line label Mar 26, 2022
@thclark
Copy link

thclark commented Apr 8, 2022

Seconded for this one - I want to provide my team a vscode devcontainer that installs everything out of the box, and don't want to have to remember to update the .devcontainer file if we add extras to the library we're developing... so sounds like the same use case as the OP.

@abn
Copy link
Member

abn commented Apr 9, 2022

Would supporting --extras . or --extras "*" as an alias for enabling all extras work here?

I am just curious if folks have a preference for --all-extras.

@l0b0
Copy link
Author

l0b0 commented Apr 10, 2022

--all-extras would be more explicit, and would avoid a) a special value or b) supporting any kind of regex, which would be another can of worms.

@kroeschl kroeschl mentioned this issue Apr 14, 2022
2 tasks
@kroeschl
Copy link
Contributor

I don't have an opinion either way, but I'd like to use this feature to make dev testing somewhat easier. I posted a PR for --all-extras: #5452

@mkniewallner mkniewallner removed the status/triage This issue needs to be triaged label Jun 11, 2022
@rjurney
Copy link

rjurney commented Jul 19, 2022

Any idea when this will be released?

@ecs-jnguyen
Copy link

It looks like the PR only got merged to master which is on version 1.2.0 beta. Could we get the --all-extras flag merged into 1.1 which is installed by default?

@rjurney
Copy link

rjurney commented Jul 27, 2022

@ecs-jnguyen @kroeschl @neersighted that would be awesome!

@Secrus
Copy link
Member

Secrus commented Jul 27, 2022

It looks like the PR only got merged to master which is on version 1.2.0 beta. Could we get the --all-extras flag merged into 1.1 which is installed by default?

There won't be any backports to 1.1 at this point. Unless anything breaks upstream (like it was for 1.1.14), there won't be another 1.1 release.

@ecs-jnguyen
Copy link

Do we have an estimate on when 1.2 stable will be released?

@neersighted
Copy link
Member

Do we have an estimate on when 1.2 stable will be released?

#5586

Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli Related to the command line kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging a pull request may close this issue.