Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add convinence extras, called "all" #38

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Conversation

aviramha
Copy link
Contributor

@aviramha aviramha commented Sep 2, 2020

No description provided.

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   82.28%   82.28%           
=======================================
  Files          10       10           
  Lines         491      491           
  Branches       43       43           
=======================================
  Hits          404      404           
  Misses         65       65           
  Partials       22       22           
Flag Coverage Δ
#unittests 82.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6625a65...d9fffc6. Read the comment docs.

@bentheiii bentheiii changed the title add convinent extras, called "all" add convinence extras, called "all" Sep 2, 2020
@@ -31,6 +31,8 @@ rabbit = ["pika"]
kafka = ["kafka-python"]
azure = ["azure-storage-blob", "cffi"]

all = ["redis", "pika", "kafka-python", "azure-storage-blob", "cffi"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no way to nest extras?

Copy link
Contributor Author

@aviramha aviramha Sep 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bentheiii bentheiii merged commit 1d889b5 into master Sep 2, 2020
@bentheiii bentheiii deleted the all_extras_group branch September 2, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants