Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New poetry-core release #5056

Closed
dimaqq opened this issue Jan 18, 2022 · 7 comments
Closed

New poetry-core release #5056

dimaqq opened this issue Jan 18, 2022 · 7 comments
Labels
kind/feature Feature requests/implementations

Comments

@dimaqq
Copy link
Contributor

dimaqq commented Jan 18, 2022

Please release the build_editable hook: 🙏🏿

https://github.com/python-poetry/poetry-core/blob/af08f1ce720da467c9bf3d43eed3d9ebaf4ad7fb/src/poetry/core/masonry/api.py#L82-L89

@dimaqq dimaqq added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Jan 18, 2022
@edgarrmondragon
Copy link
Contributor

Hi @dimaqq! Is there a reason you can't use master in the meantime?

This should work

# pyproject.toml

[build-system]
requires = ["poetry-core @ git+https://github.com/python-poetry/poetry-core.git@master"]
build-backend = "poetry.core.masonry.api"

#34 (comment)

@dimaqq
Copy link
Contributor Author

dimaqq commented Jan 19, 2022

Yes that works in the meantime, thank you @edgarrmondragon

@yaz-saleh
Copy link

@dimaqq @edgarrmondragon.. updating the build-system in pyproject.toml of my project does not seem to change anything. I am still unable to use the latest features of poetry-core that are in master. What am I missing?

@dimaqq
Copy link
Contributor Author

dimaqq commented Jan 24, 2022

I'm not the expert here, maybe it depends what frontend you use?
I used pypa/build (possibly any version?) and pip^21.3 (must be pretty new), these frontends clearly downloaded the referenced poetry-core tool and did the right thing.
I dunno about using poetry as a frontend, maybe someone else can comment?

@dimaqq
Copy link
Contributor Author

dimaqq commented Mar 2, 2022

There's a new poetry-core release and people report that it does what's needed: #34 (comment)

@dimaqq dimaqq closed this as completed Mar 2, 2022
@aaronsteers
Copy link

@dimaqq - Fantastic news - thank you! 🚀

@abn abn removed the status/triage This issue needs to be triaged label Mar 3, 2022
lobziik added a commit to lobziik/schemathesis that referenced this issue May 9, 2022
Poetry-core implements PEP660 from version 1.0.8.
This patch bumps poetry-core version in build-system section
for enable editabple installation via pip ('pip install -e .').

For more info see:
- python-poetry/poetry#34 (comment)
- python-poetry/poetry#5056
- python-poetry/poetry-core#257
lobziik added a commit to lobziik/schemathesis that referenced this issue May 9, 2022
Poetry-core implements PEP660 from version 1.0.8.
This patch bumps poetry-core version in build-system section
for enable editabple installation via pip ('pip install -e .').

For more info see:
- python-poetry/poetry#34 (comment)
- python-poetry/poetry#5056
- python-poetry/poetry-core#257
Stranger6667 pushed a commit to schemathesis/schemathesis that referenced this issue May 9, 2022
Poetry-core implements PEP660 from version 1.0.8.
This patch bumps poetry-core version in build-system section
for enable editabple installation via pip ('pip install -e .').

For more info see:
- python-poetry/poetry#34 (comment)
- python-poetry/poetry#5056
- python-poetry/poetry-core#257
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

No branches or pull requests

5 participants