Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support constraining poetry version bounds in pyproject.toml #6644

Closed
2 tasks done
brandonchinn178 opened this issue Sep 27, 2022 · 3 comments
Closed
2 tasks done

Support constraining poetry version bounds in pyproject.toml #6644

brandonchinn178 opened this issue Sep 27, 2022 · 3 comments
Labels
area/pyproject Metadata/pyproject.toml-related kind/feature Feature requests/implementations

Comments

@brandonchinn178
Copy link
Contributor

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the FAQ and general documentation and believe that my question is not already covered.

Feature Request

It would be great to include the expected poetry version bounds in pyproject.toml like

[tool.poetry.meta]
requires_poetry = "^1.2"

Where running poetry in a project with an incompatible version of Poetry throws an error. We ran into issues where we upgraded our projects to Poetry 1.2, but a developer ran with Poetry 1.1 and had things silently fail.

@brandonchinn178 brandonchinn178 added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Sep 27, 2022
@neersighted
Copy link
Member

This has been discussed multiple times, as a speculative min_poetry_version or similar, though a full constraint might be useful (but would be asymetric with how we put python in dependencies -- some bikeshedding is necessary here as design/ux will be important for this feature).

Without linking to a bunch of places, it's come up multiple time in Discussions, (private and public) Discord channels, and other issues; however, we have not had an issue to track it, so this might as well be the place.

It is worth noting that Poetry 1.1 does not fail silently; it fails loudly:

  RuntimeError

  The Poetry configuration is invalid:
    - Additional properties are not allowed ('group' was unexpected)

You could possible be referring to some other sort of incompatibility which is not graceful. We have taken steps to avoid those whenever we can (and have made changes to 1.2 to try and ease the transition), but by the nature of the long release cycle we are still discovering new sharp edges and trying to file them down. Feel free to start a discussion or similar if you are not sure what you are running into is a bug, docs issue, or just intended behavior.

@neersighted neersighted added area/pyproject Metadata/pyproject.toml-related and removed status/triage This issue needs to be triaged labels Sep 27, 2022
@finswimmer
Copy link
Member

Duplicate of #3316

@finswimmer finswimmer marked this as a duplicate of #3316 Oct 7, 2022
@finswimmer finswimmer closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2022
Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/pyproject Metadata/pyproject.toml-related kind/feature Feature requests/implementations
Projects
None yet
Development

No branches or pull requests

3 participants