Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin version of Poetry in CI to 1.5.1 to maintain support for Python 3.7 #354

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

Nour-Mws
Copy link
Collaborator

Closes #352

@Nour-Mws Nour-Mws added the CI label Aug 22, 2023
Copy link
Member

@jherland jherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing! 🚀

It occurs to me that outside of GitHub CI, we also don't really constrain the Poetry version. Sure, if you use our Nix shell, we have pinned the nixpkgs version in shell.nix, which in effect also pins Poetry at whatever version is used in that nixpkgs. But if you don't use Nix, then all bets are off.

I looked for a way to constrain the Poetry version from within pyproject.toml (it would not actually cause the right Poetry version to be used, but would at least fail loudly if the wrong version is used). However, some searching found python-poetry/poetry#6644 (and python-poetry/poetry#3316) which suggest that this is not a high priority for the Poetry team, especially not the part about restricting a newer Poetry from being used.

So in the end, I think there is not much else we can/should do for the non-GitHub situation.

@Nour-Mws Nour-Mws merged commit 0aa6b15 into main Aug 23, 2023
23 checks passed
@Nour-Mws Nour-Mws deleted the nour/fix-poetry-version branch August 23, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin Poetry version in out GitHub Action
2 participants