-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(dependency-specification): update dependency specification examp… #10171
base: main
Are you sure you want to change the base?
Conversation
…le to include directory and file paths for clarity
Reviewer's Guide by SourceryThis PR updates the dependency specification documentation to include explicit directory and file paths for local dependencies. The changes ensure that users have clear, practical examples when referencing dependencies via paths, which improves clarity and reduces potential confusion around relative vs. absolute paths. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @anqorithm - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding examples for other dependency specification methods, such as using relative paths.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
this is not a path dependency at all, it is a url dependency |
Nop @dimbleby, it's path dependency for sure. I'm using one of my own packages as a Git submodule and imported it directly as a path dependency in Poetry. Main Project (
|
It is a url dependency using the |
Hi @dimbleby, Kindly check this URL: https://python-poetry.org/docs/dependency-specification#path-dependencies And you have 2 ways to import the package from the path:
|
Hi @dimbleby, Kindly check this, URL: https://python-poetry.org/docs/dependency-specification#url-dependencies
This is an example of URL dependency, When it's using HTTP, HTTPS and importing it from github, gitlab, bitbucket, etc... |
@dimbleby bro it's very clear. |
You are mistaken. A "path dependency" is a poetry invention, there is no such thing in the standard python packaging world. This is a file url. |
I know that, then it's file url dependency, is that ok? It's really clear like soon 😶🌫️ |
Tell me @dimbleby what need to be added or changed in my PR? |
In my opinion this section of the docs is mis-organised. The split into "path" dependencies and "url" dependencies made sense when the primary syntax was poetry's own, and this distinction was real. But now that PEP621 and standard dependencies are primary it makes more sense to treat them all as url dependencies - because that's what they are. Maybe rearranging this is more than you want to take on, maybe maintainers will feel that the smaller change that you have here is an improvement anyway - even if there is more that could be done. |
Description
This PR updates the dependency specification example in the documentation to include directory and file paths for better clarity. The update ensures that users can correctly reference dependencies in various directory structures, reducing confusion when specifying dependencies in
pyproject.toml
.Changes Made
Why This Change?
Checklist
Summary by Sourcery
Clarify dependency specification examples by adding directory and file paths to guide users on referencing dependencies within different project structures.
Enhancements:
Documentation:
pyproject.toml
.