-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return a clear error when HTTP calls to legacy repo fail, instead of PackageNotFound #1072
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test covering this?
Done! I was hesitant to add tests for |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closing this pull request automatically because it has not had any activity since it has been marked as stale. If you think it is still relevant and should be addressed, feel free to open a new one. |
Any objection to reopening and merging this? I was about to make a PR for the same improvement, but this one seems perfectly good. Thanks! |
Closing this in favor of #2459 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR aims to make Poetry a bit more clear about issues when communicating with a legacy repo.
For example, it happened a few times that we would get a
PackageNotFound
error when trying to install a package from a private repo, when in fact the actual issue was bad credentials. The simple fix is simply to return the HTTP error message instead of a genericPackageNotFound
.With this change you will now see:
Instead of: