Fix METADATA generation for git dependencies with extras

[fsal]

Fixes #1114

Insert trailing space at the end of the github URL before the semicolon when extra field id specified. This trick prevents pip parser to include the semicolon (that is a avalid URL character) in the URL. In this way pip can install the wheel properly.
Tested with poetry 0.12.16,poetry 1.0.0a3 and pip 19.1.1.

---

Pull Request Check List

• Added tests for changed code.
• Updated documentation for changed code: small bug fix, no need for updated docs.

[iwoloschin]

Any chance we could get this merged soon?

[sdispater]

The base_pep_508_name property should return the base name without any extra space since this is the pre-marker part of a dependency.

This code should instead by but inside the to_pep_508() method.

[fsal]

@sdispater I moved the code to the to_pep_508() method in vcs_dependency.py. I also made the changes python2 compliant, but the appveyor job on python2.7 fails because the typing module is not present inside the environment.

[sdispater]

That won't work if there are other markers (like python_version)

[iwoloschin]

Any update on this? Thanks!

[brycedrennan]

@fsal Here is an idea that feels more explicit than finding the first semicolon.

in dependency.py Line 202

    if markers:
        if self.is_vcs():
            # url based requirements should have a space before semicolon
            # https://www.python.org/dev/peps/pep-0508/#grammar
            requirement += " "

        if len(markers) > 1:
            markers = ["({})".format(m) for m in markers]
            requirement += "; {}".format(" and ".join(markers))
        else:
            requirement += "; {}".format(markers[0])

    return requirement

Could you implement this and also If add a test case with multiple markers? If so I think we can get this merged in.

Also if you could squash all your commits together that would be nice. If not we'll do it at merge time. Thanks!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.