Fix Platform-Specific Wheel File Selection & Assign Markers (See #944 / #955)

[KyleKing]

(22Aug2019)) Update: Based on the discussion in #955, I'll be implementing marker assignment based on the wheel filenames. See discussion starting at: #955 (comment)

---

This PR implements the same functionality as PR #955, but applies the changes to the sdispater/develop branch instead of sdispater/master

Please choose whichever PR should merged and the other can be closed

---

Resolves #944 & #807

Issue: If a package only has platform_specific_wheels, Poetry just downloads the first one, which is usually cp27 and MacOSX (i.e.: numpy)

Changes: This PR adds logic to determine the best wheel file to download for Poetry supported platforms. If the best wheel can't be identified, the method falls back on the original behavior to return the first platform wheel. This fixes the [OS Error] on Windows and improves matching for Linux and Mac.

Also, tested on a couple of different computers as a sanity check (Win7-64, Win10-64, and MacOSX Mojave)

Pull Request Check List

• Added tests for changed code.
• Updated documentation for changed code. {N/A - no changes necessary}

[Pluckerpluck]

Any update on this @sdispater? Poetry is flat out broken right now. How can I possibly support any system which has remained unusable for so long? I had such high hopes for poetry as well, but it looks like I may have to move back to pipenv.

Really, all I needed was dependency resolution. But maybe the answer is to ignore that, install manually, hope for the best and test a lot more... Then just lock those dependencies.

The other problem Windows is facing has also received no love. It's why the errors have been so unhelpful (this error masks other problems) and in a few unlucky cases again flat out breaks poetry on Windows.

[areeh]

looks like this would fix most of our current build issues

[KyleKing]

The PR is basically done, but I'm not going to push it further as this is no longer an issue now that poetry better picks the downloaded file. The current logic in poetry ^0.12.17 is sufficient

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.