Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping on tests/conftest.py #1271

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Housekeeping on tests/conftest.py #1271

merged 1 commit into from
Sep 5, 2019

Conversation

dazza-codes
Copy link
Contributor

@dazza-codes dazza-codes commented Jul 31, 2019 •
edited
Loading

Housekeeping on tests/conftest.py

  • remove duplicate tmp_dir fixture
  • alphabetize fixture functions
  • place functions above fixtures
  • apply the PyCharm "optimize imports"
  • use pytest.yield_fixture

checklist

  • doesn't apply here, but adding it for the sake of it
  • Added tests for changed code
  • Updated documentation for changed code

brycedrennan
brycedrennan suggested changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@brycedrennan brycedrennan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

Could you rebase to resolve conflicts and switch back to just using fixture?

tests/conftest.py Outdated Show resolved Hide resolved
@dazza-codes dazza-codes force-pushed the dedup-conftest branch 2 times, most recently from 930880c to ae7ff5a Compare August 10, 2019 00:03
@dazza-codes
Copy link
Contributor Author

Tried to rebase on develop and resolve conflicts, hope that helps.

@brycedrennan brycedrennan added the area/testing Related to the test suite label Aug 15, 2019
Optimize tests/conftest.py
f38081b 
- apply the PyCharm "optimize imports"
- place functions above fixtures
- alphabetize fixture functions
- remove duplicate tmp_dir fixture
@dazza-codes
Copy link
Contributor Author

PRs are moving very slowly, any plans to merge this?

  • if PRs like this are not merged quickly, there's a risk they fall behind and need extra attention to rebase them again (and again)

@brycedrennan brycedrennan added the kind/refactor Pulls that refactor, or clean-up code label Sep 5, 2019
@brycedrennan brycedrennan merged commit 7b13f00 into python-poetry:develop Sep 5, 2019
@dazza-codes dazza-codes deleted the dedup-conftest branch September 5, 2019 15:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brycedrennan brycedrennan brycedrennan approved these changes

Assignees
No one assigned
Labels
area/testing Related to the test suite kind/refactor Pulls that refactor, or clean-up code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dazza-codes @brycedrennan