Fix ValueError when finding packages with invalid metadata #1346
Conversation
There was a problem hiding this comment.
Thanks for tackling this.
A couple things:
- It looks like a test could go in
test_pypi_repository.py. You could mock out ServerProxy to return test data with invalid versions. - If possible, I'd like to more narrowly catch the error. With a testcase it will be easier to see if this is possible
Some packages (like `pygame-music-grid`) have unparseable metadata. This resulted in a ValueError. pip ignores packages like these, so it's reasonable to do the same in poetry itself and only display the well-formed ones. Fixes python-poetry#1345. Fixes python-poetry#637.
sztomi
force-pushed
the
fix_pygame_search
branch
from
c7dd55b
to
7ea16fa
Compare
|
Hi @brycedrennan, I updated my branch with:
|
| 'Unable to parse version "{}" for the {} package, skipping'.format( | ||
| hit["version"], hit["name"] | ||
| ), | ||
| level="debug", |
There was a problem hiding this comment.
I wonder if this should be a warning that's printed to the shell? This way it's much more likely that someone will raise the issue with the upstream.
There was a problem hiding this comment.
I think there is a fairly large number of malformed (and abandoned) packages on pypi that are easy to run into when you search for a fragment of a package name. This is almost the same logging that is done in find_packages in the same file.
There was a problem hiding this comment.
Good point - and it would still show up when running with higher verbosity, right?
|
Thanks! |
|
N.B. This does not fix having already-installed packages with un-parseable versions. It seems to only fix Poetry searches that result in unparseable versions. See #2167. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Some packages (like
pygame-music-grid) have unparseable metadata. This resulted in a ValueError. pip ignores packages like these, so it's reasonable to do the same in poetry itself and only display the well-formed ones.Fixes #1345.
Pull Request Check List