Detect Conda when looking for a virtual env #1432

maksbotan · 2019-10-01T19:00:33Z

Currently Poetry will detect that it is running in a usual virtual env
created with "python -m venv" and will not create an additional env.

This commit extends this logic to Conda, which uses different
environment variables to indicate running in a virtual env.

Conda's "base" env is treated specially to avoid polluting global
namespace.

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

Added tests for changed code.
Updated documentation for changed code.

Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the develop branch. If it's a bug fix or only a documentation update, it should be based on the master branch.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

edisongustavo · 2019-10-07T18:11:05Z

This is amazing and I'm looking forward to this PR!

kasteph · 2019-10-12T07:27:25Z

@sdispater I just took a look at this PR and it looks good to me -- can we get this in 1.0 or 1.1?

sdispater · 2019-10-18T13:41:32Z

@stephsamson I think we can add it for the 1.0 release.

@maksbotan Can you rebase your branch onto the master branch?

maksbotan · 2019-10-18T13:43:56Z

@sdispater just to clarify, master, not dev, correct?

sdispater · 2019-10-18T13:57:45Z

@maksbotan Yes, master since it's the branch containing the code for the 1.0.0 release.

Currently Poetry will detect that it is running in a usual virtual env created with "python -m venv" and will not create an additional env. This commit extends this logic to Conda, which uses different environment variables to indicate running in a virtual env. Conda's "base" env is treated specially to avoid polluting global namespace.

maksbotan · 2019-10-18T14:34:23Z

Well, I did it :)

maksbotan · 2019-10-18T15:06:50Z

Thanks a lot!
By the way, are there any plans for 1.0 release date?

Currently Poetry will detect that it is running in a usual virtual env created with "python -m venv" and will not create an additional env. This commit extends this logic to Conda, which uses different environment variables to indicate running in a virtual env. Conda's "base" env is treated specially to avoid polluting global namespace.

dbalabka · 2020-06-07T17:35:07Z

poetry/utils/env.py

+        conda_env_name = os.environ.get("CONDA_DEFAULT_ENV")
+        # It's probably not a good idea to pollute Conda's global "base" env, since
+        # most users have it activated all the time.
+        in_venv = env_prefix is not None and conda_env_name != "base"


@maksbotan, @stephsamson it is useful to allow poetry install into "base" environment when we create Docker image because there no need to create multiple Conda environments inside the container.
Otherwise, the developer should be aware that Poetry will ignore "base" environment. It would be great to output a warning/notice message about this.

RoelantStegmann · 2020-10-06T16:07:30Z

Just wondering: will poetry solve with taking the conda packages into account? I couldn't really find that in the documentation and I had a bit of a confusing situation.

I recently did on a windows computer did

poetry install

But in my code I got complaints that numpy was not properly installed. So I installed it with conda, where we had only a version before available...

conda install numpy=1.19.1

And now I still get

(test) λ poetry show numpy
name         : numpy
version      : 1.19.2

(test) λ pip show numpy
Name: numpy
Version: 1.19.2

(test) λ poetry run python -c "import numpy; print(numpy.__version__)"
1.19.1

Only after poetry remove numpy it shows the correct version.

nlhnt · 2021-02-17T16:49:32Z

I don't think this is working, speaking from Windows. Same thing as above happesn for pytest and anything else I'm trying to use in a poetry / conda project.

poetry show -v with dependencies commented out:

$ poetry show -v
$ Using virtualenv: C:\Users\username\.conda\envs\phy_sec

poetry show -v with dependencies defined, numpy = "^1.17"

Using virtualenv: C:\Users\username\.conda\envs\phy_sec

  Stack trace:

  6  ~\.conda\envs\phy_sec\lib\site-packages\clikit\console_application.py:131 in run
     status_code = command.handle(parsed_args, io)

  5  ~\.conda\envs\phy_sec\lib\site-packages\clikit\api\command\command.py:120 in handle
     status_code = self._do_handle(args, io)

  4  ~\.conda\envs\phy_sec\lib\site-packages\clikit\api\command\command.py:171 in _do_handle
     return getattr(handler, handler_method)(args, io, self)

  3  ~\.conda\envs\phy_sec\lib\site-packages\cleo\commands\command.py:92 in wrap_handle
     return self.handle()

  2  ~\.conda\envs\phy_sec\lib\site-packages\poetry\console\commands\show.py:82 in handle
     ops = solver.solve()

  1  ~\.conda\envs\phy_sec\lib\site-packages\poetry\puzzle\solver.py:65 in solve
     packages, depths = self._solve(use_latest=use_latest)

  SolverProblemError

  Because pyforming depends on numpy (^1.17) which doesn't match any versions, version solving failed.

  at ~\.conda\envs\phy_sec\lib\site-packages\poetry\puzzle\solver.py:241 in _solve
      237│             packages = result.packages
      238│         except OverrideNeeded as e:
      239│             return self.solve_in_compatibility_mode(e.overrides, use_latest=use_latest)
      240│         except SolveFailure as e:
    → 241│             raise SolverProblemError(e)
      242│
      243│         results = dict(
      244│             depth_first_search(
      245│                 PackageNode(self._package, packages), aggregate_package_nodes

conda list with grep to look for a dependency installed in conda env under test

conda list | select-string "numpy"
numpy                     1.17.4                   pypi_0    pypi
numpydoc                  0.9.1                      py_0    conda-forge

phiresky · 2021-02-25T15:01:49Z

Is there any way to disable this functionality? I only want to use conda for the python binary and system compiler etc, not for the environment. Now poetry just never creates an environment and instead installs its stuff in the conda env.

austinmw · 2023-03-24T20:14:15Z

Would also like to know how to disable this

maksbotan · 2023-03-24T20:20:32Z

@austinmw as far as I remember this change, poetry would use Conda env if you specifically created one, distinct from Conda's base. My argument is that you made the env for a reason and it doesn't make sense to create another env, kinda nested in Conda's. Does this contradict your work flow?

By the way, I think this behavior might be broken in the latest releases. I believe I even reported the issue.

austinmw · 2023-03-26T16:09:19Z

@austinmw as far as I remember this change, poetry would use Conda env if you specifically created one, distinct from Conda's base. My argument is that you made the env for a reason and it doesn't make sense to create another env, kinda nested in Conda's. Does this contradict your work flow?

By the way, I think this behavior might be broken in the latest releases. I believe I even reported the issue.

Ah okay, I didn’t realize that this functionality doesn’t kick in for the base environment. That works for me then, thanks!

github-actions · 2024-03-03T22:48:32Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

kasteph added kind/feature Feature requests/implementations area/venv Related to virtualenv management labels Oct 5, 2019

kasteph approved these changes Oct 15, 2019

View reviewed changes

finswimmer mentioned this pull request Oct 17, 2019

Conda compatibility #105

Closed

maksbotan force-pushed the conda-integration branch from f2c0d28 to b1058fc Compare October 18, 2019 14:33

maksbotan changed the base branch from develop to master October 18, 2019 14:34

kasteph mentioned this pull request Oct 18, 2019

Any plans to make it work with anaconda python? #190

Closed

kasteph merged commit 01b01aa into python-poetry:master Oct 18, 2019

thorbjornwolf mentioned this pull request Dec 13, 2019

Document use of current conda env #1724

Closed

1 task

dbalabka reviewed Jun 7, 2020

View reviewed changes

padix-key mentioned this pull request Jun 9, 2020

Switching setup to Poetry biotite-dev/biotite#214

Closed

8 tasks

0x2b3bfa0 mentioned this pull request Feb 1, 2021

Hard dependency on anaconda MolecularAI/aizynthfinder#19

Closed

glima mentioned this pull request Apr 6, 2021

Deprecate old term gallery in favor of new "Marketplace". microsoft/lisa#1259

Merged

github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Detect Conda when looking for a virtual env #1432

Detect Conda when looking for a virtual env #1432

maksbotan commented Oct 1, 2019

edisongustavo commented Oct 7, 2019

kasteph commented Oct 12, 2019

sdispater commented Oct 18, 2019

maksbotan commented Oct 18, 2019

sdispater commented Oct 18, 2019

maksbotan commented Oct 18, 2019

maksbotan commented Oct 18, 2019

dbalabka Jun 7, 2020

RoelantStegmann commented Oct 6, 2020

nlhnt commented Feb 17, 2021 •

edited

Loading

phiresky commented Feb 25, 2021

austinmw commented Mar 24, 2023 •

edited

Loading

maksbotan commented Mar 24, 2023

austinmw commented Mar 26, 2023

github-actions bot commented Mar 3, 2024

Detect Conda when looking for a virtual env #1432

Detect Conda when looking for a virtual env #1432

Conversation

maksbotan commented Oct 1, 2019

Pull Request Check List

edisongustavo commented Oct 7, 2019

kasteph commented Oct 12, 2019

sdispater commented Oct 18, 2019

maksbotan commented Oct 18, 2019

sdispater commented Oct 18, 2019

maksbotan commented Oct 18, 2019

maksbotan commented Oct 18, 2019

dbalabka Jun 7, 2020

Choose a reason for hiding this comment

RoelantStegmann commented Oct 6, 2020

nlhnt commented Feb 17, 2021 • edited Loading

poetry show -v with dependencies commented out:

poetry show -v with dependencies defined, numpy = "^1.17"

conda list with grep to look for a dependency installed in conda env under test

phiresky commented Feb 25, 2021

austinmw commented Mar 24, 2023 • edited Loading

maksbotan commented Mar 24, 2023

austinmw commented Mar 26, 2023

github-actions bot commented Mar 3, 2024

nlhnt commented Feb 17, 2021 •

edited

Loading

austinmw commented Mar 24, 2023 •

edited

Loading