Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve password management #1788

Merged
merged 1 commit into from
Dec 26, 2019
Merged

Improve password management #1788

merged 1 commit into from
Dec 26, 2019

Conversation

sdispater
Copy link
Member

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

This PR is a refactoring of the password management of Poetry. This alleviates some of the keyring shortcomings and delays the import of keyring to only
when it's needed to avoid the CLI hanging because of it (see #1779).

Fixes #1779
Fixes #1719
Fixes #1565
Fixes #1335

@sdispater sdispater requested a review from a team December 23, 2019 21:39
@K900
Copy link
Contributor

K900 commented Dec 25, 2019

Would be really nice to see the keyring dependency bumped to something like >=19.0 on Python 3. It makes source built Poetry not run on Arch...

@sdispater sdispater merged commit 299a885 into master Dec 26, 2019
@sdispater sdispater deleted the improve-password-management branch December 26, 2019 16:36
@Ivoz
Copy link

Ivoz commented Dec 27, 2019

Unfortunately keyring 19.0 drops python 2.7, so you'd have to figure out what you want to do about that

@danieleades
Copy link
Contributor

hi there, i'm still seeing these issues on ubuntu 18.04.

the system library of keyrings.alt is being picked up, and it's trying to import keyring.util.escape, which doesn't exist in the vendored version of keyring (but does in the system version). Does this merge really fix the root cause of #1719 and #1335, or does it just postpone the import so that only some commands are broken?

If there's any other details i can provide, or a more appropriate place to report this, please let me know!

@christian-hawk
Copy link

Happens on github actions ubuntu/latest too.

Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants