Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pypi package name in pyproject.toml #2305

Merged
merged 2 commits into from
Aug 16, 2020
Merged

use pypi package name in pyproject.toml #2305

merged 2 commits into from
Aug 16, 2020

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Apr 14, 2020

read package name from pypi info['info']['name']

Pull Request Check List

Resolves: #2098

  • Added tests for changed code.
    Updated documentation for changed code.

read package name from pypi info .info.name
close #2098
@finswimmer finswimmer requested a review from a team June 3, 2020 18:42
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks a lot for your contribution.

@finswimmer finswimmer merged commit 0d48fb6 into python-poetry:master Aug 16, 2020
@trim21 trim21 deleted the use-pypi-package-name branch August 16, 2020 07:03
@sdispater sdispater mentioned this pull request Sep 18, 2020
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save canonical PyPi names in pyproject.toml
2 participants