recurse clone submodules

[matemax]

Fixes: #1828
Closes: #611

Pull Request Check List

• Added tests for changed code.
  I not found how implement test for these case
• Updated documentation for changed code.
  I not found docs about clone git dependencies.

[matemax]

closes #1828

[matemax]

@finswimmer, i rebase and reopen(#1826 )

[matemax]

Any Feedback?

[finswimmer]

LGTM 👍

Thanks a lot.

[fabiopedrosa]

@finswimmer @matemax for me this merge has broken the use of https:// .... .git schema. e.g. this now fails:

[CalledProcessError]
Command '['git', 'clone', '--recurse-submodules', 'https://github.com/darklow/django-suit.git', 'C:\\Temp\\pypoetry-git-django-su0mrul0xy']' returned non-zero exit status 128.

[finswimmer]

Hello @fabiopedrosa ,

could you please open a new issue for this and describe how one can reproduce the problem?

fin swimmer

[matemax]

Hello @fabiopedrosa, the command

git clone --recurse-submodules https://github.com/darklow/django-suit.git C:\\Temp\\pypoetry-git-django-su0mrul0xy

executes correct

[luisacabs-out]

Can you please add documentation on how to use this?

[Zeskbest]

Can you please add documentation on how to use this?

This pr fixes complicated libraries installation.
If a git-sourced library has a submodule, this submodule is not cloned during the install, so library is installed incorrectly. Don't use it. It must be used by default.

[luisacabs-out]

@Zeskbest what do you mean it must be used by default?
What I'm trying to do is install a package from a specific module in my private repo. This repo has multiple independent packages. I can do this by running:

poetry run pip git+ssh:/git@github.com/myrepo#subdirectory=my_pkg

But I would like to specify this dependency in my pyproject.toml. Not sure how I should do it, this is not documented as far as I know

[finswimmer]

@luisacabs-out: What you try is to install a package from a subfolder within a git repository. This is not supported at the moment by poetry. Some links you can follow:

• Dependency rooted in a subfolder of a GIT repository #755
• support git subfolder poetry-core#9 (comment)
• Better git handling poetry-core#192

[Zeskbest]

@Zeskbest what do you mean it must be used by default?
What I'm trying to do is install a package from a specific module in my private repo. This repo has multiple independent packages. I can do this by running:

poetry run pip git+ssh:/git@github.com/myrepo#subdirectory=my_pkg

But I would like to specify this dependency in my pyproject.toml. Not sure how I should do it, this is not documented as far as I know

You should make a library from your repo (see here).
Make a submodule from the subdirectory my_pkg if needed.
Than add it to the .toml file:

[tool.poetry.dependencies.myrepo]
git = "ssh:/git@github.com/myrepo.git"
tag = "v.0.0.1"

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.