Add log warning if auth fails when accessing repository #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finswimmer
added
the
area/error-handling
3 tasks
|
Would be nice to also have a 401 check. In my case it was a 401 with |
This causes the error code handler to also check for 401 status as well, since servers return 401 for different auth errors.
|
@austinbutler added this as well. Thanks! |
abn
approved these changes
Sep 24, 2020
Merged
3 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2576
This just adds a more informative error message in the event that a repository fails due to an authorization error. Right now, poetry fails silently on that case.
I tried to add tests here, but because this is part of the core
_getmethod, I couldn't really do so using the existing mock. I could perform mocking at therequestslevel, but wasn't sure if that was the usual way in the poetry project. Let me know the best way to test this.Thanks!
Tim