Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency overrides for packages with multiple duplicate dependencies #2622

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

sdispater
Copy link
Member

Whenever a package had multiple duplicate dependencies the overrides system was buggy and only retained one overridden version leading to resolution errors at installation times.

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater added the area/solver Related to the dependency resolver label Jul 3, 2020
@sdispater sdispater added this to the 1.1 milestone Jul 3, 2020
@sdispater sdispater requested a review from a team July 3, 2020 09:48
@abn abn merged commit feef53b into develop Jul 3, 2020
@abn abn deleted the fix-dependency-overrides branch July 3, 2020 12:09
@sdispater sdispater mentioned this pull request Jul 10, 2020
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/solver Related to the dependency resolver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants